Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider length of string keys #308

Merged
merged 2 commits into from
Oct 29, 2024
Merged

consider length of string keys #308

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e1b707
consider length of string keys
mdrossmiller Oct 25, 2024
835f356
accept review suggestion
mdrossmiller Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/hash/str_set.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ DEFINE_HASH_TABLE(str_set)
*/
static inline int ht_match(const void *key, size_t len, str_set_item_t item)
{
return strncmp(key, item, len) == 0;
return len == strlen(item) && strncmp(key, item, len) == 0;
}
mdrossmiller marked this conversation as resolved.
Show resolved Hide resolved

static inline const void *ht_key(str_set_item_t item)
Expand Down