-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate CI jobs for macOS on x86 #284
Conversation
The pre-installed gcc 13.3 (brew package 'gcc-13') only seems to work with an older MacOSX.sdk version than the default in a macos-12 runner. By setting a specific version gcc will use matching headers like: /Applications/Xcode_14.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/Availability.h Add a check if the compiler is already installed, which silences a warning.
Thanks for looking into this. Would it make more sense to move to a newer macos runner? Staying compatible with multiple versions old macos might not be worthwhile since Apple generally doesn't seem pay much attention to backwards compat. Also, if there is a newer it might be a more important test case? |
I guess it would be better to run on later runner releases. The only "issue" I know is that macos-14 is running on M1 machines only and older packages from Hombrew releases are not always available. But building on both x86_64 and arm64 would be good thing anyway. Maybe we should have a build matrix in the job |
yeah, my only concern is that this gets a bit complicated, and the explicit xcode version should hopefully not be necessary, but have no clear understanding of this. I'm thinking maybe it is better to separate out the x86 build to a separate target and try to keep the M1+ as clean as possible? The x86 will likely get deprecated at some point, and if there are any issues, it will be easier to kill off. |
It looks like there a fixes incoming for a (new) gcc-14 that handles various SDK headers: Yea, it gets a bit complicated with theses matrixes.. I can make an attempt by moving x86 to its own jobs, and maybe see if we could go for gcc-14 instead if that works without switching Xcode version.. |
sounds like a plan, thanks |
Looks fine, but: |
Lift macos runner in CI and only install needed tools.
So, been of a bit with the flu, but now the warnings should be gone in both CI and weekly. |
Thanks, looks great, get well soon! |
Thanks!
They are probably temporary, but still.. I'll put them in my backlog to see if there are ways to avoid them |
Split the CI jobs for testing Mac to run on both "old" x86 runners and the new M1 runner.
The pre-installed gcc 13.3 (brew package
gcc-13
) only seems to work with an older MacOSX.sdk version than the default in a macos-12 runner.Lets update to
gcc-14
which has been corrected to be able to use any SDK version.This PR also adds a check if the compiler is already installed, which silences a warning.
Weekly run:
https://github.com/Nordix/flatcc/actions/runs/9413941834