Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ruby 3.0 with updated dependencies #106

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

albertico-gov
Copy link

@albertico-gov albertico-gov commented Jan 4, 2023

Updating this project to use Ruby 3.0.5. No major Rails update was made.

The following changes were also made in conjunction:

  • Updated gems: rails, sqlite3, puma, sass-rails, webpacker, turbolinks, jbuilder, bootsnap, fhir_models, rubocop-minitest, rubocop-rake, web-console, listen, rack-mini-profiler, capybara.
  • Updated Dockerfile to use Ruby 3.0.5.
  • Updated Gemfile.lock files (using bundler 2.4.2)
  • Updated Node.js to LTS version 18.12.1
  • Updated config/webpacker.yml, babel.config.js, package.json and yarn.lock using webpacker.
  • Compilation of packs via bin/webpack required setting export NODE_OPTIONS=--openssl-legacy-provider to avoid errors.
  • Updated db/schema.rb to the version generated by bin/setup.
  • Modified README.md to reflect the Ruby version update.

This solves #105

* Updated gems with latest version as of 2022-01-03
* .ruby-version

* .tool-versions

* .rubocop.yml

* Gemfile
* Gemfile.lock

* test_app/Gemfile.lock
* config/webpacker.yml

* babel.config.js

* package.json

* yarn.lock
* The setup script produces an updated db schema definition based
  on current migrations. Committing updated schema for consistency.
@albertico-gov
Copy link
Author

albertico-gov commented Jan 4, 2023

Hey @radamson and @ssayer , tagging you here for awareness.

@radamson
Copy link
Contributor

radamson commented Jan 5, 2023

Thank you for the pull request and these updates!

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #106 (a9ac25b) into main (ee12a25) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          24       24           
  Lines         548      548           
=======================================
  Hits          528      528           
  Misses         20       20           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@albertico-gov
Copy link
Author

albertico-gov commented Jan 11, 2023

@radamson Seems that there are some linting issues that need to be resolved. I started going through them but the fixes will require various i18n-related changes across the project. Should those be committed as part of this pull request or would it make more sense to push those in another pull request?

@nscott nscott mentioned this pull request Jan 17, 2023
@radamson
Copy link
Contributor

radamson commented Jan 19, 2023

Commiting those changes to this PR would be great if you are willing to take a stab at it! I can also look into fixing the linting issues and then open a PR into this one if you don't beat me too it.

Thank you again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants