Merge pull request HubSpot#210 from yannleretaille/master

fixes issue that occurs when a previously registered event handler calls .off/.on
dustwolf · Jun 15, 2016 · 0b30fa8 · 0b30fa8
2 parents 99aceda + 6875efc
commit 0b30fa8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/coffee/offline.coffee b/coffee/offline.coffee
@@ -115,7 +115,8 @@ Offline.off = (event, handler) ->
 
 Offline.trigger = (event) ->
   if handlers[event]?
-    for [ctx, handler] in handlers[event]
+    # we have to make a copy of the handlers since its possible that the called functions will modify the handlers array by calling off/on 
+    for [ctx, handler] in handlers[event][..]
       handler.call(ctx)
 
 checkXHR = (xhr, onUp, onDown) ->