fix high cpu utilzation when autoaddmgr is running on JsonServer #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix high cpu utilization
The JsonServer is experiencing high cpu utilzation of above 90% when autoaddmgr thread is enabled even when IP manager is idel without any activities from motes.
Description of the issue
Further investigation leads to this part of the code at smartmeshsdk/libs/SmartMeshSDK/utils/SerialScanner.py:
The code is looping in a NON-BLOCKING manner, and therefore keep the CPU busy at all time.
Proposed changes for fixing the issue
To introduce a delay (blocking) into the loop. My test shows that by adding merely 0.01s sleep into the while loop will bring the cpu utilization from 90+% down to about 3.5% running on a beaglebone black host.
I'm proposing to add 0.1s delay into the loop: