[sparkle] default container to dialog if it exists (#10936)

* default container to dialog if it exists * bump * Target sheets as deefault portal container * fixed default
dust-tt · Feb 19, 2025 · abf71d1 · abf71d1
1 parent 5335486
commit abf71d1
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/sparkle/package-lock.json b/sparkle/package-lock.json
diff --git a/sparkle/package.json b/sparkle/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dust-tt/sparkle",
-  "version": "0.2.408",
+  "version": "0.2.409",
   "scripts": {
     "build": "rm -rf dist && npm run tailwind && npm run build:esm && npm run build:cjs",
     "tailwind": "tailwindcss -i ./src/styles/tailwind.css -o dist/sparkle.css",

diff --git a/sparkle/src/components/Popover.tsx b/sparkle/src/components/Popover.tsx
@@ -55,8 +55,16 @@ const PopoverContent = React.forwardRef<
       />
     );
 
+    const dialogElements = document.querySelectorAll(
+      ".s-sheet[role=dialog][data-state=open]"
+    );
+
+    const defaultContainer = dialogElements[dialogElements.length - 1];
+
     return mountPortal ? (
-      <PopoverPrimitive.Portal container={mountPortalContainer}>
+      <PopoverPrimitive.Portal
+        container={mountPortalContainer || defaultContainer}
+      >
         {content}
       </PopoverPrimitive.Portal>
     ) : (

diff --git a/sparkle/src/components/Sheet.tsx b/sparkle/src/components/Sheet.tsx
@@ -98,7 +98,7 @@ const SheetContent = React.forwardRef<
     <FocusScope trapped={trapFocusScope} asChild>
       <SheetPrimitive.Content
         ref={ref}
-        className={cn(sheetVariants({ size, side }), className)}
+        className={cn(sheetVariants({ size, side }), className, "s-sheet")}
         {...props}
       >
         {children}