Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: use external timestamp to generate genesis_block #2427

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Sep 18, 2024

Resolves #2431

This is a best effort PR

Proper solution would be to move the chain settings from rusk.toml to rusk.settings

Those settings should contain:

  • Genesis Timestamp (default to UNIX_EPOCH for tests)
  • Genesis Seed (default to [0u8;48] for tests
  • ChainId (default to 0 for tests)
  • Genesis state root (default ask to VM)

See #2430

fed-franz
fed-franz previously approved these changes Sep 19, 2024
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit de00a73 into master Sep 23, 2024
11 checks passed
@herr-seppia herr-seppia deleted the genesis_ts branch September 23, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node: Take genesis timestamp as parameter
3 participants