Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet-core: adjust lib for FFI usage #2422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wallet-core: adjust lib for FFI usage #2422

wants to merge 1 commit into from

Conversation

ZER0
Copy link
Contributor

@ZER0 ZER0 commented Sep 18, 2024

  • Add ITEM_SIZE and KEY_SIZE globals
  • Change balance:calculate to check the notes' ownership
  • Add balance::calculate_unchecked to skip the ownsership's check
  • Change FFI map_owned to return also max block_height and last_pos

@ZER0
wallet-core: adjust lib for FFI usage
5e868ef 
- Add `ITEM_SIZE` and `KEY_SIZE` globals
- Change `balance:calculate` to check the notes' ownership
- Add `balance::calculate_unchecked` to skip the ownsership's check
- Change FFI `map_owned` to return also max `block_height` and `last_pos`
@ZER0 ZER0 requested a review from moCello September 18, 2024 10:28
@ZER0 ZER0 marked this pull request as ready for review September 18, 2024 10:28
moCello
moCello approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would only like to have a code comment on the KEY_SIZE and ITEM_SIZE to clarify what key and item they refer to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moCello moCello moCello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZER0 @moCello