Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace temporary custom webamp bundle and add macos media keys #10

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

durasj
Copy link
Owner

@durasj durasj commented Mar 17, 2019

All ideas come from the @captbaritone.

@captbaritone
Copy link

Are you running type checking on Travis? I would expect this to fail type checking since track.defaultTitle is not present on the argument passed to the onTrackDidChange callback.

Also, there are some @ts-ignore comments in src/renderer.ts which can probably be cleaned up.

@captbaritone
Copy link

Looks good!

@durasj
Copy link
Owner Author

durasj commented Mar 17, 2019

@captbaritone

Are you running type checking on Travis? I would expect this to fail type checking since track.defaultTitle is not present on the argument passed to the onTrackDidChange callback.

Unfortunately, no, parcel won't report those currently to me. I plan to change that later together with a rewrite of the main process part to the TS. Thanks for the heads up, is there please now any alternative to the defaultTitle?

Also, there are some @ts-ignore comments in src/renderer.ts which can probably be cleaned up.

Ah, right, done :)

Thank you very much for checking this!

@durasj durasj mentioned this pull request Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants