Skip to content

Commit

Permalink
Merge pull request #316 from huanyichuang/master
Browse files Browse the repository at this point in the history
fix the i18n missing strings
  • Loading branch information
duracelltomi authored Jan 12, 2024
2 parents 00c827f + c2caec6 commit ab03f23
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions admin/admin-tab-integrate.php
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,11 @@
'label' => esc_html__( 'Google Consent Mode', 'duracelltomi-google-tag-manager' ),
'description' => sprintf(
// translators: 1: opening anchor tag linking to Google's documentation about the consent mode command. 2: Closing anchor tag.
gtm4wp_safe_admin_html(
'Enable this checkbox if you wish to execute the "default" command of %1$sGoogle Consent Mode%2$s before the container loads.
gtm4wp_safe_admin_html( __( 'Enable this checkbox if you wish to execute the "default" command of %1$sGoogle Consent Mode%2$s before the container loads.
The "update" command needs to be executed from your consent management tool.<br /><br />
DO NOT enable this feature if your consent manager tool supports firing both the "default" and the "update" command.',
'duracelltomi-google-tag-manager'
),
) ),
'<a href="https://developers.google.com/tag-platform/gtagjs/reference#consent" target="_blank" rel="noopener">',
'</a>'
),
Expand Down
2 changes: 1 addition & 1 deletion admin/admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ function gtm4wp_admin_init() {
GTM4WP_ADMIN_GROUP_GENERAL,
array(
'label_for' => GTM4WP_ADMIN_GROUP_CONTAINERON,
'description' => gtm4wp_safe_admin_html( 'Turning OFF the Google Tag Manager container itself will remove both the head and the body part of the container code but leave data layer codes working.<br/>This should be only used in specific cases where you need to place the container code manually or using another tool.', 'duracelltomi-google-tag-manager' ),
'description' => gtm4wp_safe_admin_html( __( 'Turning OFF the Google Tag Manager container itself will remove both the head and the body part of the container code but leave data layer codes working.<br/>This should be only used in specific cases where you need to place the container code manually or using another tool.', 'duracelltomi-google-tag-manager' ) ),
)
);

Expand Down

0 comments on commit ab03f23

Please sign in to comment.