Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update duolingo pre-commit hook to 1.8.0 (TOOLS-581) #63

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

artnc
Copy link
Member

@artnc artnc commented Dec 10, 2024

Description

This yearly upgrade does the following and should be pretty safe:

  • Adds support for autoformatting Go, C++, TOML
  • Reduces the Docker image size by 60%
  • Updates Prettier/Ruff/ktfmt/etc to their latest versions
    • Most notable new feature: Kotlin trailing commas
  • Updates Splinter (if present) to respect splinter:ignore comments

Click here to view the Pulldozer transformation script used to create this PR
#!/usr/bin/env sh

COMMIT_MESSAGE='Update `duolingo` pre-commit hook to 1.8.0 (TOOLS-581)'

transform() {
  # Update pre-commit hook
  replace_all '(repo: https://github.com/duolingo/pre-commit-hooks\.git.+rev: ).+(\n +hooks:\n +- id: duolingo)' '\11.8.0\2' '\.pre-commit-config\.yaml$'
  duo format || true

  # Update Splinter
  duo replace '(repo: https://github.com/duolingo/splinter\.git.+rev: ).+(\n +hooks:\n +- id: splinter)' '\11.4.0\2' '\.pre-commit-config\.yaml$'
}

# duo hound '^    rev: 1\.[0-7]\.[0-4]$' '^\.pre-commit-config\.yaml$' | cut -d/ -f1 | uniq
REPOS='
duolingo/minject
duolingo/metasearch
duolingo/pulldozer
duolingo/splinter
'

DESCRIPTION='## Description

This yearly upgrade does the following and should be pretty safe:

- Adds support for autoformatting Go, C++, TOML
- Reduces the Docker image size by 60%
- Updates Prettier/Ruff/ktfmt/etc to their latest versions
  - Most notable new feature: Kotlin trailing commas
- Updates [Splinter](https://github.com/duolingo/splinter) (if present) to respect `splinter:ignore` comments'

@artnc artnc enabled auto-merge (squash) December 10, 2024 03:32
@artnc artnc merged commit 0ff9f38 into master Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants