Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub action for type checking with mypy #42

Merged
merged 29 commits into from
Jul 17, 2024
Merged

Add GitHub action for type checking with mypy #42

merged 29 commits into from
Jul 17, 2024

Conversation

xiyan128
Copy link
Contributor

@xiyan128 xiyan128 commented Jul 17, 2024 •
edited
Loading

  • Added CI job to run mypy on PR and master push
  • Also added CI badges to readme

@duolingo
Copy link

duolingo bot commented Jul 17, 2024

⚠️ Alek Binion is OOO tomorrow. Consider assigning someone else instead.

@xiyan128 xiyan128 changed the base branch from master to github_action_for_ci July 17, 2024 16:08
@duolingo duolingo bot changed the base branch from github_action_for_ci to master July 17, 2024 16:16
@xiyan128 xiyan128 merged commit afb19b5 into master Jul 17, 2024
8 checks passed
@duolingo
Copy link

duolingo bot commented Jul 17, 2024

⚠️ @mmchenry-duolingo please take a look at these post-approval changes

@duolingo duolingo bot deleted the github_action_for_typecheck branch July 17, 2024 16:27
This was referenced Jul 17, 2024
Closed
Closed
@biniona biniona removed their assignment Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmchenry-duolingo mmchenry-duolingo mmchenry-duolingo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiyan128 @mmchenry-duolingo @biniona