spec!: add support for several topic matcher types, including URL Pattern #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Oct 16, 2024
spec/mercure.md
Outdated
| * Topic matcher: An expression intended to be matched by one or several topics, | ||
| depending on the matcher type. | ||
| * Topic matcher type: Several types of matchers **MAY** be supported by the hub. The hub **MUST** support exact matching of topic and **SHOULD** support | ||
| matching topics using I-Regexp [@!RFC9485], URL patterns [@!urlpattern] and URI Templates [@!RFC6570] as |
There was a problem hiding this comment.
I'd say:
should support at least one of the following topic matchers:
There was a problem hiding this comment.
I'll improve this by adding a table.
| Link: <https://example.com/.well-known/mercure>; rel="mercure" | ||
|
|
||
| {"@id": "/books/foo", "foo": "bar", "@context": {"@language": "fr-FR"}} | ||
| ~~~ |
There was a problem hiding this comment.
nothing has changed there it just got moved?
Co-authored-by: Antoine Bluchet <[email protected]>
Co-authored-by: Antoine Bluchet <[email protected]>
Co-authored-by: Antoine Bluchet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #831 with a more flexible and future-proof approach.
Summary
topicquery parameter becomesmatchand now only supports exact matchingmatch{MatchType}matchRegexp,matchURLPattern, andmatchURITemplateare definedThe official hub will be able to support both the current and new protocols simultaneously (no hard BC break).
TODO: