-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic metrics #966
add basic metrics #966
Conversation
4a93deb
to
cd6080b
Compare
b80dcf7
to
58dd673
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition!
Thank you very much for this patch.
I made some quite minor comments, can't wait to use this.
In a follow-up PR, we should also update the performance guide because this will help users find good production values. We could maybe create a script to help finding these values using these metrics.
@dunglas, anything else you want to see in this PR or is it good to merge? |
oh, wait. Docs! |
This reverts commit 1f0df6f.
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
1dd671a
to
733fb9a
Compare
This adds a collection of basic metrics based on feedback in #269:
frankenphp_busy_threads
: shows current php threads processing php scripts (including workers waiting for requests)frankenphp_total_threads
: shows the total number of running php threadsfrankenphp_[worker]_busy_workers
: shows how many workers are currently processing requestsfrankenphp_[worker]_total_workers
: shows the total amount of workers.frankenphp_[worker]_worker_request_count
: shows the total requests processed by each workerfrankenphp_[worker]_worker_request_time
: shows the total time taken processing requestsCurrently, it uses the filename of the registered worker as a key. Ideally, the user would be able to name the worker and use that instead. I'm not sure if we want to do that in this PR.
Here's currently one worker running on my machine: