Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take until the end #935

Merged
merged 4 commits into from
Jan 8, 2024
Merged

take until the end #935

merged 4 commits into from
Jan 8, 2024

Conversation

duluca
Copy link
Owner

@duluca duluca commented Jan 6, 2024

Feature/Change Description

Describe changes made here, link to any issue that is addressed

Developer Checklist

  • Updated documentation or README.md
  • If adding new feature(s), added and ran unit tests
  • If create new release, bumped version number
  • Ran npm run style:fix for code style enforcement
  • Ran npm run lint:fix for linting
  • Ran npm audit to discover vulnerabilities

Copy link

gitguardian bot commented Jan 8, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
34587 OpenWeatherMap Token 4f6fbe4 cypress/e2e/simple-search.cy.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@duluca duluca merged commit 551fba3 into main Jan 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant