Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop local asset support #324

Merged
merged 6 commits into from
Aug 24, 2024
Merged

Conversation

duguyihou
Copy link
Owner

No description provided.

@duguyihou duguyihou merged commit bff55ce into main Aug 24, 2024
8 checks passed
@duguyihou duguyihou deleted the refactor-drop-local-asset-support branch August 24, 2024 22:44
@ng-ha
Copy link

ng-ha commented Aug 26, 2024

@duguyihou oh no, why did you drop local asset support?

@duguyihou
Copy link
Owner Author

@ng-ha

To support local asset, we need consider different types of images(svg, gif, apng...) as well. Besides, RN image works well with local asset and supports different uris. data:, res:. I don't have capacity to do that, especially for Android. Then I realised that I should keep it in a small scope and not try to replace RN image. Maybe we can put it back in the future.

@duguyihou
Copy link
Owner Author

@ng-ha

are you using TurboImage with local asset?

@ng-ha
Copy link

ng-ha commented Aug 26, 2024

@duguyihou yes, i am. RN Image doesn't support some special formats of images

@duguyihou
Copy link
Owner Author

@ng-ha

Can you tell me which formats are you using? Last week, I encountered some issues with local assets in Android release mode.

  • app crash with svg
  • apng does not play.

@ng-ha
Copy link

ng-ha commented Aug 26, 2024

I tried local apng in debug mode, it worked fine. I haven't tried in release mode yet

@duguyihou
Copy link
Owner Author

sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants