Adds type=button (#190)

* Uses type button so form submission is not triggered * version bump * prettier
duffelhq · Dec 14, 2023 · bf060ed · bf060ed
1 parent a297c37
commit bf060ed
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@duffel/components",
-  "version": "3.1.8",
+  "version": "3.1.9",
   "description": "Component library to build your travel product with Duffel.",
   "keywords": [
     "Duffel",

diff --git a/src/components/DuffelAncillaries/bags/BaggageSelectionModalHeader.tsx b/src/components/DuffelAncillaries/bags/BaggageSelectionModalHeader.tsx
@@ -57,6 +57,7 @@ const InactiveSegment: React.FC<{
   onClick?: React.MouseEventHandler<HTMLButtonElement>;
 }> = ({ onClick, style }) => (
   <button
+    type="button"
     onClick={onClick}
     style={{
       border: "none",

diff --git a/src/components/DuffelAncillaries/seats/SeatElement.tsx b/src/components/DuffelAncillaries/seats/SeatElement.tsx
@@ -87,6 +87,7 @@ export const SeatElement: React.FC<SeatElementProps> = ({
   return (
     <>
       <button
+        type="button"
         data-testid={`seat-${element.designator}`}
         id={element.designator}
         className={seatClassName}

diff --git a/src/components/DuffelAncillaries/seats/SeatSelectionModalHeader.tsx b/src/components/DuffelAncillaries/seats/SeatSelectionModalHeader.tsx
@@ -72,6 +72,7 @@ const InactiveSegment: React.FC<{
   onClick?: React.MouseEventHandler<HTMLButtonElement>;
 }> = ({ onClick, style }) => (
   <button
+    type="button"
     onClick={onClick}
     style={{
       border: "none",

diff --git a/src/components/PlacesLookup/PlacesLookup.tsx b/src/components/PlacesLookup/PlacesLookup.tsx
@@ -93,6 +93,7 @@ export const PlacesLookup: React.FC<PlacesLookupProps> = ({
           >
             {lookupResults.map(({ item }, index) => (
               <button
+                type="button"
                 className="places-lookup-popover__item"
                 key={item.iata_code + index}
                 onClick={() => {