This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
API: Cities #96
Open
API: Cities #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ulissesalmeida, are you able to review these changes? |
Time moves on and the ages in these examples are no longer valid. These changes replace static ages with calculated equivalents so that they can be rerun at any time with confidence.
|
Too long! Hope that you're doing well. 💝 |
Dependabot: Manage GitHub Actions updates
Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile.
Pull test case out of setup.
- Remove Ruby 2.6: rubocop >= 1.51.0 depends on Ruby >= 2.7.0 - Add modern, generally available Ruby versions: 3.2, 3.3
Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
Style/RedundantInterpolation: Prefer to_s over string interpolation.
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Examples: time aware passenger ages
- Style/SuperArguments: Call super without arguments and parentheses when the signature is identical. - Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies)
sgerrand
force-pushed
the
cities-api
branch
from
2874d4d
to
9ca56c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 These changes:
DuffelAPI::Resources::Airport.new.cityto return aDuffelAPI::Resource::Citygc_ruboconfig,rubocopgems