Parse & add the missing API details #287

MaziyarMK · 2023-06-10T21:50:19Z

offer request owner (airline) logo
offer request slice segment stops

Add missing fields to Airline dataclass

ulissesalmeida

Looks pretty good to me.

I added a few comments to keep the file consistent.

duffel_api/models/offer.py

ulissesalmeida

LGTM

jesse-c

LGTM aside from needing the test fixtures updated! Thanks for your work on this, @MaziyarMK.

jesse-c · 2023-06-13T10:22:23Z

duffel_api/models/airline.py

@@ -11,6 +11,8 @@ class Airline:
    id: str
    name: str
    iata_code: Optional[str]
+    logo_lockup_url: Optional[str]


test: Could you please add examples of these to the test fixture? [1][2]

[1]

duffel-api-python/tests/fixtures/get-airlines.json

Lines 3 to 7 in 3f01a35

{

"iata_code": "BA",

"id": "aln_00001876aqC8c5umZmrRds",

"name": "British Airways"

}

[2]

{ "iata_code": "BA", "id": "aln_00001876aqC8c5umZmrRds", "name": "British Airways", "logo_lockup_url": "https://assets.duffel.com/img/airlines/for-light-background/full-color-lockup/BA.svg", "logo_symbol_url": "https://assets.duffel.com/img/airlines/for-light-background/full-color-logo/BA.svg" }

jesse-c · 2023-06-13T10:23:57Z

duffel_api/models/offer.py

+    """Additional segment-specific information about the stops, if any, included in the segment"""
+
+    id: str
+    duration: str


test: Similar request here to add some stops to the test fixture [1].

[1]

duffel-api-python/tests/fixtures/get-offers.json

Lines 135 to 208 in 3f01a35

{

"aircraft": {

"iata_code": "380",

"id": "arc_00009UhD4ongolulWd91Ky",

"name": "Airbus Industries A380"

},

"arriving_at": "2020-06-13T16:38:02",

"departing_at": "2020-06-13T16:38:02",

"destination": {

"city": {

"iata_code": "NYC",

"iata_country_code": "US",

"id": "cit_nyc_us",

"name": "New York"

},

"city_name": "New York",

"iata_code": "JFK",

"iata_country_code": "US",

"icao_code": "KJFK",

"id": "arp_jfk_us",

"latitude": 40.640556,

"longitude": -73.778519,

"name": "John F. Kennedy International Airport",

"time_zone": "America/New_York"

},

"destination_terminal": "5",

"distance": "424.2",

"duration": "PT02H26M",

"id": "seg_00009htYpSCXrwaB9Dn456",

"marketing_carrier": {

"iata_code": "BA",

"id": "aln_00001876aqC8c5umZmrRds",

"name": "British Airways"

},

"marketing_carrier_flight_number": "1234",

"operating_carrier": {

"iata_code": "BA",

"id": "aln_00001876aqC8c5umZmrRds",

"name": "British Airways"

},

"operating_carrier_flight_number": "4321",

"origin": {

"city": {

"iata_code": "LON",

"iata_country_code": "GB",

"id": "cit_lon_gb",

"name": "London"

},

"city_name": "London",

"iata_code": "LHR",

"iata_country_code": "GB",

"icao_code": "EGLL",

"id": "arp_lhr_gb",

"latitude": 64.068865,

"longitude": -141.951519,

"name": "Heathrow",

"time_zone": "Europe/London"

},

"origin_terminal": "B",

"passengers": [

{

"baggages": [

{

"quantity": 1,

"type": "checked"

}

],

"cabin_class": "economy",

"cabin_class_marketing_name": "Economy Basic",

"fare_basis_code": "OXZ0RO",

"passenger_id": "passenger_0"

}

]

}

jesse-c · 2023-06-13T10:26:33Z

duffel_api/models/airline.py

@@ -11,6 +11,8 @@ class Airline:
    id: str
    name: str
    iata_code: Optional[str]
+    logo_lockup_url: Optional[str]


future: We need to add conditions_of_carriage_url [1] as well.

[1] https://duffel.com/docs/api/v1/airlines/schema#airlines-schema-conditions-of-carriage-url.

jesse-c · 2023-06-13T10:34:16Z

duffel_api/models/offer.py

@@ -221,6 +221,32 @@ def from_json(cls, json: dict):
        )


+@dataclass
+class OfferSliceSegmentStop:
+    """Additional segment-specific information about the stops, if any, included in the segment"""


fix: This line is too long [1]. You can fix it by running tox -e linting or flake8 locally.

[1] https://github.com/duffelhq/duffel-api-python/actions/runs/5245627223/jobs/9476358835?pr=287

jesse-c · 2023-06-13T10:43:28Z

duffel_api/models/offer.py

+            arriving_at=get_and_transform(
+                json, "arriving_at", parse_datetime
+            ),
+            departing_at=get_and_transform(
+                json, "departing_at", parse_datetime
+            ),


fix: The reason for the static analysis (pyright) failures is that this helper function, get_and_transform, is for when values are optional.

Those 2 aren't, so you can parse them directly.

Suggested change

arriving_at=get_and_transform(

json, "arriving_at", parse_datetime

),

departing_at=get_and_transform(

json, "departing_at", parse_datetime

),

arriving_at=parse_datetime(json["arriving_at"]),

departing_at=parse_datetime(json["departing_at"]),

Ahh sorry, it was my bad

MaziyarMK added 3 commits June 11, 2023 00:21

Add missing fields to Airline dataclass

6bfb921

Merge pull request #1 from MaziyarMK/patch-1

db8d297

Add missing fields to Airline dataclass

receive and parse segment stops

00358a8

MaziyarMK requested a review from a team as a code owner June 10, 2023 21:50

ulissesalmeida reviewed Jun 12, 2023

View reviewed changes

duffel_api/models/offer.py Show resolved Hide resolved

duffel_api/models/offer.py Outdated Show resolved Hide resolved

resolve maintainer/reviewer comments

8408d86

ulissesalmeida approved these changes Jun 12, 2023

View reviewed changes

jesse-c reviewed Jun 13, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse & add the missing API details #287

Parse & add the missing API details #287

MaziyarMK commented Jun 10, 2023

ulissesalmeida left a comment

ulissesalmeida left a comment

jesse-c left a comment

jesse-c Jun 13, 2023 •

edited

Loading

jesse-c Jun 13, 2023

jesse-c Jun 13, 2023

jesse-c Jun 13, 2023 •

edited

Loading

jesse-c Jun 13, 2023

ulissesalmeida Jun 13, 2023

	{
	"iata_code": "BA",
	"id": "aln_00001876aqC8c5umZmrRds",
	"name": "British Airways"
	}

	{
	"aircraft": {
	"iata_code": "380",
	"id": "arc_00009UhD4ongolulWd91Ky",
	"name": "Airbus Industries A380"
	},
	"arriving_at": "2020-06-13T16:38:02",
	"departing_at": "2020-06-13T16:38:02",
	"destination": {
	"city": {
	"iata_code": "NYC",
	"iata_country_code": "US",
	"id": "cit_nyc_us",
	"name": "New York"
	},
	"city_name": "New York",
	"iata_code": "JFK",
	"iata_country_code": "US",
	"icao_code": "KJFK",
	"id": "arp_jfk_us",
	"latitude": 40.640556,
	"longitude": -73.778519,
	"name": "John F. Kennedy International Airport",
	"time_zone": "America/New_York"
	},
	"destination_terminal": "5",
	"distance": "424.2",
	"duration": "PT02H26M",
	"id": "seg_00009htYpSCXrwaB9Dn456",
	"marketing_carrier": {
	"iata_code": "BA",
	"id": "aln_00001876aqC8c5umZmrRds",
	"name": "British Airways"
	},
	"marketing_carrier_flight_number": "1234",
	"operating_carrier": {
	"iata_code": "BA",
	"id": "aln_00001876aqC8c5umZmrRds",
	"name": "British Airways"
	},
	"operating_carrier_flight_number": "4321",
	"origin": {
	"city": {
	"iata_code": "LON",
	"iata_country_code": "GB",
	"id": "cit_lon_gb",
	"name": "London"
	},
	"city_name": "London",
	"iata_code": "LHR",
	"iata_country_code": "GB",
	"icao_code": "EGLL",
	"id": "arp_lhr_gb",
	"latitude": 64.068865,
	"longitude": -141.951519,
	"name": "Heathrow",
	"time_zone": "Europe/London"
	},
	"origin_terminal": "B",
	"passengers": [
	{
	"baggages": [
	{
	"quantity": 1,
	"type": "checked"
	}
	],
	"cabin_class": "economy",
	"cabin_class_marketing_name": "Economy Basic",
	"fare_basis_code": "OXZ0RO",
	"passenger_id": "passenger_0"
	}
	]
	}

Parse & add the missing API details #287

Are you sure you want to change the base?

Parse & add the missing API details #287

Conversation

MaziyarMK commented Jun 10, 2023

ulissesalmeida left a comment

Choose a reason for hiding this comment

ulissesalmeida left a comment

Choose a reason for hiding this comment

jesse-c left a comment

Choose a reason for hiding this comment

jesse-c Jun 13, 2023 • edited Loading

Choose a reason for hiding this comment

jesse-c Jun 13, 2023

Choose a reason for hiding this comment

jesse-c Jun 13, 2023

Choose a reason for hiding this comment

jesse-c Jun 13, 2023 • edited Loading

Choose a reason for hiding this comment

jesse-c Jun 13, 2023

Choose a reason for hiding this comment

ulissesalmeida Jun 13, 2023

Choose a reason for hiding this comment

jesse-c Jun 13, 2023 •

edited

Loading

jesse-c Jun 13, 2023 •

edited

Loading