Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update imap-codec and use new poison feature #268

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

jakoschiko
Copy link
Collaborator

No description provided.

@jakoschiko
Copy link
Collaborator Author

Depends on duesee/imap-codec#592

@coveralls
Copy link
Collaborator

coveralls commented Aug 20, 2024

Pull Request Test Coverage Report for Build 10761422132

Details

  • 19 of 32 (59.38%) changed or added relevant lines in 1 file are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.7%) to 80.967%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/receive.rs 19 32 59.38%
Files with Coverage Reduction New Missed Lines %
src/receive.rs 23 61.68%
Totals Coverage Status
Change from base Build 10761324189: -1.7%
Covered Lines: 1021
Relevant Lines: 1261

💛 - Coveralls

@soywod
Copy link
Contributor

soywod commented Aug 30, 2024

Depends on duesee/imap-codec#592

The PR was merged, so I guess this one can be merged too?

@jakoschiko
Copy link
Collaborator Author

Is there another alpha release of imap-codec that we can depend on?

@jakoschiko
Copy link
Collaborator Author

@duesee Any objections on creating another imap-codec release to unblock this PR?

@duesee
Copy link
Owner

duesee commented Sep 8, 2024

Nope, will do 👍🏻 Will just finish up some minor PRs.

@duesee
Copy link
Owner

duesee commented Sep 8, 2024

Done, see ...

@jakoschiko jakoschiko force-pushed the jakoschiko_poison-message-with-fragmentizer branch from a8c5a7f to d8fd582 Compare September 8, 2024 15:34
@jakoschiko jakoschiko marked this pull request as ready for review September 8, 2024 15:35
@jakoschiko jakoschiko requested a review from duesee September 8, 2024 15:35
@duesee duesee force-pushed the jakoschiko_poison-message-with-fragmentizer branch from d8fd582 to a0bb3c4 Compare September 8, 2024 16:09
@jakoschiko jakoschiko force-pushed the jakoschiko_poison-message-with-fragmentizer branch from a0bb3c4 to 0f962d4 Compare September 8, 2024 16:24
@soywod
Copy link
Contributor

soywod commented Sep 8, 2024

Awesome! So this PR can be merged now?

@duesee duesee merged commit 75671ca into main Sep 8, 2024
7 checks passed
@duesee duesee deleted the jakoschiko_poison-message-with-fragmentizer branch September 8, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants