Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature!: Add max_response_size for Client #254

Merged
merged 2 commits into from
Jul 14, 2024
Merged

feature!: Add max_response_size for Client #254

merged 2 commits into from
Jul 14, 2024

Conversation

jakoschiko
Copy link
Collaborator

Closes #253

@coveralls
Copy link
Collaborator

coveralls commented Jul 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9931080664

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 80 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-4.8%) to 77.19%
Files with Coverage Reduction New Missed Lines %
src/client.rs 80 57.81%
Totals Coverage Status
Change from base Build 9928174712: -4.8%
Covered Lines: 1022
Relevant Lines: 1324
💛 - Coveralls

@jakoschiko jakoschiko force-pushed the jakoschiko_max-response-size branch 2 times, most recently from 407389c to 710df5e Compare July 13, 2024 22:57
@jakoschiko jakoschiko marked this pull request as ready for review July 13, 2024 22:57
@jakoschiko jakoschiko requested a review from duesee July 13, 2024 22:57
duesee
duesee reviewed Jul 14, 2024
View reviewed changes
src/client.rs Outdated Show resolved Hide resolved
@jakoschiko jakoschiko force-pushed the jakoschiko_max-response-size branch from 038b802 to 7397653 Compare July 14, 2024 21:42
@jakoschiko jakoschiko force-pushed the jakoschiko_max-response-size branch from 7397653 to 34a2c80 Compare July 14, 2024 22:12
@jakoschiko jakoschiko merged commit a145537 into main Jul 14, 2024
7 checks passed
@jakoschiko jakoschiko deleted the jakoschiko_max-response-size branch July 14, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duesee duesee duesee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Max response size for Client
3 participants
@jakoschiko @coveralls @duesee