Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for crlf_relaxed to false #133

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Change default for crlf_relaxed to false #133

merged 2 commits into from
Feb 21, 2024

Conversation

jakoschiko
Copy link
Collaborator

Closes #116.

Adds some tests for #118.

@jakoschiko jakoschiko requested a review from duesee February 20, 2024 23:20
@jakoschiko jakoschiko force-pushed the jakoschiko_change-default-for-crlf-relaxed branch from ffe7517 to 1823d5f Compare February 20, 2024 23:22
@jakoschiko jakoschiko force-pushed the jakoschiko_change-default-for-crlf-relaxed branch from 1823d5f to e8833a2 Compare February 20, 2024 23:23
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7981404265

Details

  • 0 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.07%
Totals Coverage Status
Change from base Build 7979996470: 0.0%
Covered Lines: 591
Relevant Lines: 1135
💛 - Coveralls

@jakoschiko jakoschiko mentioned this pull request Feb 20, 2024
Closed
12 tasks
duesee
duesee approved these changes Feb 21, 2024
View reviewed changes
Copy link
Owner

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

src/client.rs Show resolved Hide resolved
@jakoschiko jakoschiko merged commit 2a51bd2 into main Feb 21, 2024
10 checks passed
@jakoschiko jakoschiko deleted the jakoschiko_change-default-for-crlf-relaxed branch February 21, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duesee duesee duesee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default for crlf_relaxed to false
3 participants
@jakoschiko @coveralls @duesee