Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve selection of TS2322 vs TS2741 #760

Merged
merged 20 commits into from
Feb 26, 2023
Merged

fix: Improve selection of TS2322 vs TS2741 #760

merged 20 commits into from
Feb 26, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 26, 2023 •
edited
Loading

Description:

This PR introduces report_assign_failure_for_missing_properties in AssignOpts which can be used to select between TS2322 and TS2471 for the caller side.

@kdy1 kdy1 added this to the v0.0.1: Correctness milestone Feb 26, 2023
@github-actions
Copy link

github-actions bot commented Feb 26, 2023 •
edited
Loading

Thank you for the PR!
Commit: 118b663

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

@kdy1 kdy1 changed the title fix: Fix objectTypeWithStringAndNumberIndexSignatureToAny.ts fix: Fix TS2322 vs TS2471 Feb 26, 2023
@kdy1 kdy1 changed the title fix: Fix TS2322 vs TS2471 fix: Fix TS2322 vs TS2751 Feb 26, 2023
@kdy1 kdy1 changed the title fix: Fix TS2322 vs TS2751 fix: Fix TS2322 vs TS2741 Feb 26, 2023
@kdy1 kdy1 changed the title fix: Fix TS2322 vs TS2741 fix: Fix TS2322 vs TS2741 for type elements Feb 26, 2023
@kdy1 kdy1 changed the title fix: Fix TS2322 vs TS2741 for type elements fix: Fix TS2322 vs TS2741 Feb 26, 2023
@kdy1 kdy1 changed the title fix: Fix TS2322 vs TS2741 fix: Improve selection of TS2322 vs TS2741 Feb 26, 2023
@kdy1 kdy1 marked this pull request as ready for review February 26, 2023 03:20
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 26, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) February 26, 2023 03:20
@kdy1 kdy1 mentioned this pull request Feb 26, 2023
Closed
@kdy1
Copy link
Member Author

kdy1 commented Feb 26, 2023

I stopped working on this PR because we need other tasks to continue working on assignments. (#761, #762)

@kdy1 kdy1 merged commit 24599a0 into dudykr:main Feb 26, 2023
@kdy1 kdy1 deleted the d92 branch February 26, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodiakhq kodiakhq kodiakhq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.0.1: Correctness
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1