Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: implement ambient comment #1100

Closed
wants to merge 2 commits into from

Conversation

sunrabbit123
Copy link
Collaborator

@sunrabbit123 sunrabbit123 commented Oct 13, 2023

Description:

//@Filename: decls.ts
// Ambient external module with export assignment
declare module 'equ' {
    var x;
    export = x;
}

declare module 'equ2' {
    var x: number;
}

// Ambient external import declaration referencing ambient external module using top level module name
//@Filename: consumer.ts
/// <reference path="decls.ts" />
import imp1 = require('equ');


// Ambient external module members are always exported with or without export keyword when module lacks export assignment
import imp3 = require('equ2');
var n = imp3.x;
var n: number;

BREAKING CHANGE:

Related issue (if exists):

@sunrabbit123 sunrabbit123 changed the title [WIP] feat: implement ambient tags [WIP] feat: implement ambient comment Oct 13, 2023
@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Thank you for the PR!
Commit: 399cd7c

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

@sunrabbit123 sunrabbit123 added this to the v0.0.1: Correctness milestone Oct 16, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

⚠️ No Changeset found

Latest commit: 399cd7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant