Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support accessing nom primitive constraint of an empty object #1072

Merged
merged 2 commits into from
Aug 20, 2023
Merged

feat: Support accessing nom primitive constraint of an empty object #1072

merged 2 commits into from
Aug 20, 2023

Conversation

sunrabbit123
Copy link
Collaborator

@sunrabbit123 sunrabbit123 commented Aug 19, 2023 •
edited
Loading

Description:

function l<T extends {}, P extends keyof T>(s: string, tp: T[P]): void {
    tp = s;
}

BREAKING CHANGE:

Related issue (if exists):

@sunrabbit123 sunrabbit123 mentioned this pull request Aug 19, 2023
Merged
8 tasks
@github-actions
Copy link

Thank you for the PR!
Commit: 86b831f

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

@kdy1 kdy1 changed the title fix: nom primitive constriant of indexed access type at empty object feat: Support accessing nom primitive constraint of an empty object Aug 20, 2023
@kdy1 kdy1 enabled auto-merge (squash) August 20, 2023 03:16
kdy1
kdy1 approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 merged commit 96ad01d into dudykr:main Aug 20, 2023
8 checks passed
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 20, 2023
@sunrabbit123
feat: Support accessing nom primitive constraint of an empty object (d…
924ae3e 
…udykr#1072)

**Description:**

```ts
function l<T extends {}, P extends keyof T>(s: string, tp: T[P]): void {
    tp = s;
}
```
@sunrabbit123 sunrabbit123 deleted the fix/7 branch August 20, 2023 16:17
@sunrabbit123 sunrabbit123 mentioned this pull request Aug 22, 2023
Closed
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 30, 2023
@sunrabbit123
feat: Support accessing nom primitive constraint of an empty object (d…
b08b690 
…udykr#1072)

**Description:**

```ts
function l<T extends {}, P extends keyof T>(s: string, tp: T[P]): void {
    tp = s;
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunrabbit123 @kdy1