Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix panic from parse().unwrap() at generic inference #1070

Merged
merged 3 commits into from
Aug 20, 2023

Conversation

sunrabbit123
Copy link
Collaborator

Description:

 if r.is_num() {
      match src.parse() {
          Ok(v) => {
              return Type::Lit(LitType {
                  span,
                  lit: RTsLit::Number(RNumber { span, value: v, raw: None }),
                  metadata: Default::default(),
                  tracker: Default::default(),
              })
          }
          Err(..) => {
              return Type::Keyword(KeywordType {
                  span,
                  kind: TsKeywordTypeKind::TsNumberKeyword,
                  metadata: Default::default(),
                  tracker: Default::default(),
              })
          }
      }
  }

BREAKING CHANGE:

Related issue (if exists):

@github-actions
Copy link

github-actions bot commented Aug 19, 2023

Thank you for the PR!
Commit: 0999c3a

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 changed the title Fix: panic from parse().unwrap() at generic inference fix: Fix panic from parse().unwrap() at generic inference Aug 20, 2023
@kdy1 kdy1 enabled auto-merge (squash) August 20, 2023 03:17
@kdy1 kdy1 merged commit 277b967 into dudykr:main Aug 20, 2023
7 checks passed
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 20, 2023
)

**Description:**

```rs
 if r.is_num() {
      match src.parse() {
          Ok(v) => {
              return Type::Lit(LitType {
                  span,
                  lit: RTsLit::Number(RNumber { span, value: v, raw: None }),
                  metadata: Default::default(),
                  tracker: Default::default(),
              })
          }
          Err(..) => {
              return Type::Keyword(KeywordType {
                  span,
                  kind: TsKeywordTypeKind::TsNumberKeyword,
                  metadata: Default::default(),
                  tracker: Default::default(),
              })
          }
      }
  }
```
@sunrabbit123 sunrabbit123 deleted the fix/5 branch August 20, 2023 16:17
@sunrabbit123 sunrabbit123 added this to the v0.0.1: Correctness milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants