test: Support more directives in file analyzer testing system #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Thank you for the PR! Files to checkThese are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message. You can run |
kdy1
changed the title
sunrabbit123
added a commit
to sunrabbit123/stc
that referenced
this pull request
Aug 30, 2023
…#1069) **Description:** When comparing TSC to error, we took the error results from ACTUAL. In actual, the rules for each file were not applied properly, As a result, tests like strictNullCheck didn't work correctly. To fix this, we unified the env import code within the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When comparing TSC to error, we took the error results from ACTUAL.
In actual, the rules for each file were not applied properly,
As a result, tests like strictNullCheck didn't work correctly.
To fix this, we unified the env import code within the tests.
BREAKING CHANGE:
Related issue (if exists):