Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate inferred generic types #1053

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Conversation

sunrabbit123
Copy link
Collaborator

Description:

interface A<T extends string> {}
type a = A<number> // required error, not reported

BREAKING CHANGE:

Related issue (if exists):
#956

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Thank you for the PR!
Commit: 1a77ce2

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

@sunrabbit123 sunrabbit123 marked this pull request as ready for review July 5, 2023 18:13
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 changed the title Feat: Implement typeParam validation from generic feat: Validate inferred generic types Aug 7, 2023
@kdy1 kdy1 merged commit dcacac1 into dudykr:main Aug 7, 2023
1 check passed
@kdy1 kdy1 added this to the v0.0.1: Correctness milestone Aug 7, 2023
@sunrabbit123 sunrabbit123 deleted the patch-1 branch August 8, 2023 16:24
@sunrabbit123 sunrabbit123 mentioned this pull request Aug 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants