Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New July Privacy Pro promotion for new installs #85

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

amddg44
Copy link
Collaborator

@amddg44 amddg44 commented Jul 9, 2024

Task: https://app.asana.com/0/1207619243206445/1207546055898910/f

This PR enables a Privacy Pro promotion for new installs

Testing Steps:

  1. Update RemoteMessagingClient to use the staging URL from the comments below as the debug URL
  2. Drag in BSK so that local code changes can be made. In RemoteMessagingConfigProcessor.swift update shouldProcessConfig to always return true
  3. Ensure the device you are testing on has the locale region set to the US
  4. Sign out of Privacy Pro (if already signed in)
  5. Test that the install date range is working by overriding daysSinceInstall value (search for line case let matchingAttribute as DaysSinceInstalledMatchingAttribute in UserAttributeMatcher.swift) to test the range. Try it with 0, 4, and 12, and check that the message only appears for the 4 case
  6. Sign in to Privacy Pro and confirm the message no longer appears
  7. Finally, sign back out and confirm clicking the link takes you to the Privacy Pro sign up flow

@amddg44 amddg44 requested a review from a team as a code owner July 9, 2024 16:06
@amddg44 amddg44 requested review from jaceklyp and removed request for a team July 9, 2024 16:06
Copy link

github-actions bot commented Jul 9, 2024

@amddg44 amddg44 requested a review from samsymons July 9, 2024 16:12
amddg44 and others added 4 commits July 9, 2024 18:34
# Via GitHub
* main:
  Remove iOS July 2024 survey (#83)

# Conflicts:
#	live/ios-config/ios-config.json
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested various configurations of the desired parameters, including making sure that the message shows up for eligible users who don't already have an account, and that it does not appear for ineligible users or those who are eligible but are already signed in. I also tested that the action works as expected.

This PR had merge conflicts with a prior PR, so I've resolved those in order to get the correct value deployed to staging as part of testing - hope that's okay!

@amddg44 amddg44 merged commit e810c4f into main Jul 10, 2024
1 check passed
@samsymons samsymons deleted the anya/privacy-pro-promo-new-installs branch August 7, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants