Add config files for macOS and Windows #80
Conversation
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| SOURCE_DIR: 'live/macos-config' | ||
| DEST_DIR: 'remotemessaging/config/staging/pre' |
There was a problem hiding this comment.
we can drop pre from the dest_dir
(also update message)
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| SOURCE_DIR: 'live/windows-config' | ||
| DEST_DIR: 'remotemessaging/config/staging/pre' |
| AWS_REGION: 'us-east-1' | ||
| SOURCE_DIR: 'live/macos-config' | ||
| DEST_DIR: 'remotemessaging/config/v1' | ||
| - uses: jakejarvis/s3-sync-action@7ed8b112447abb09f1da74f3466e4194fc7a6311 |
There was a problem hiding this comment.
I think the reason why iOS publishes here into staging is an old bug with Urls where they were consuming staging/pre in test builds, stating in release builds. We can remove this step here.
@amddg44 do you remember if this is correct?
There was a problem hiding this comment.
@cmonfortep currently iOS uses a sample empty config in test builds and production in release builds. So I think we 're safe to make it work the same way as Android workflow (which I did).
There was a problem hiding this comment.
Can we check if there are no users consuming remotemessaging/config/staging in production on iOS?
There was a problem hiding this comment.
Yeah so I've reverted iOS changes in the end :)
| AWS_REGION: 'us-east-1' | ||
| SOURCE_DIR: 'live/macos-config' | ||
| DEST_DIR: 'remotemessaging/config/v1' | ||
| - uses: jakejarvis/s3-sync-action@7ed8b112447abb09f1da74f3466e4194fc7a6311 |
Task/Issue URL: https://app.asana.com/0/72649045549333/1207587223508406/f
Description:
This change adds empty config files for macOS and Windows and workflows to publish them to production and staging
(copied over from existing iOS workflows and adjusted as needed).