Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS Permanent survey last day to 14 #107

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Oct 7, 2024

https://app.asana.com/0/1206488453854252/1208492802071664/f

This PR updates the macOS day 5 survey, increasing the last day from 8 to 14. Note to @samsymons - I’ve not yet familiar with RMF, so it’s worth checking the associated Asana task to ensure I made the right changes. Thanks!

How to test:

Before you start, you'll need to be using English as your device's language - this survey targets en-US, en-CA, en-GB, and en-AU.

  1. Update RemoteMessagingClient.swift's debug URL to use the macOS staging URL
  2. Next, we need to simulate having installed the app between 5 and 14 days ago; to do this, you'll need to drop a local copy of BSK onto your project so that you can edit it, open UserAttributeMatcher.swift, then look for the line case let matchingAttribute as DaysSinceInstalledMatchingAttribute. Edit the logic inside this case to change the value of daysSinceInstall to between 5-14. (Note: we have an option for changing the install date in the debug menu, but I think it affects a key that is separate from the statistics store - need to look into it further)
  3. Launch the app, open the Debug menu's Remote Messaging Config section, select "Reset Remote Messages", then select "Refresh Messages" in the same Debug menu
  4. Open a new tab and the message should appear - click the survey URL and make sure it opens as expected, and that parameters look sensible

@aataraxiaa aataraxiaa requested a review from samsymons October 7, 2024 18:15
Copy link

github-actions bot commented Oct 7, 2024

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only thing missing was an increase of the version field, but I've pushed a commit that does that. Feel free to merge any time, and thanks for this change!

@aataraxiaa aataraxiaa merged commit 3d16773 into main Oct 10, 2024
1 check passed
@aataraxiaa aataraxiaa deleted the pete/mac-d5-survey-increase-days branch October 10, 2024 06:02
samsymons added a commit that referenced this pull request Oct 11, 2024
* main:
  Update macOS Permanent survey last day to 14 (#107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants