Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Ai Chat feature now it's released to preview. #2734

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

Jonathan-L
Copy link
Contributor

Asana Task/Github Issue:
https://app.asana.com/0/1206272239963149/1208518098397240

Description

AI Chat has been released to preview, so it's time to update the remote config to enable the feature flag.

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Reference

@Jonathan-L Jonathan-L requested review from a team as code owners February 6, 2025 18:53
Copy link

github-actions bot commented Feb 6, 2025

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Feb 6, 2025

Generated file outputs:

Time updated: Thu, 06 Feb 2025 19:11:52 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json

⚠️ File is identical

v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -71,18 +71,19 @@
             "exceptions": [],
             "minSupportedVersion": "0.100.0"
         },
         "aiChat": {
-            "state": "disabled",
+            "state": "enabled",
             "exceptions": [],
             "features": {
                 "toolbarShortcut": {
-                    "state": "disabled"
+                    "state": "enabled"
                 },
                 "applicationMenuShortcut": {
-                    "state": "disabled"
+                    "state": "enabled"
                 }
             },
+            "minSupportedVersion": "0.100.0",
             "settings": {
                 "aiChatURL": "https://duckduckgo.com/?q=DuckDuckGo+AI+Chat&ia=chat&duckai=3",
                 "onboardingCookieName": "dcm",
                 "onboardingCookieDomain": "duckduckgo.com",
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json

⚠️ File is identical

v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -71,18 +71,19 @@
             "exceptions": [],
             "minSupportedVersion": "0.100.0"
         },
         "aiChat": {
-            "state": "disabled",
+            "state": "enabled",
             "exceptions": [],
             "features": {
                 "toolbarShortcut": {
-                    "state": "disabled"
+                    "state": "enabled"
                 },
                 "applicationMenuShortcut": {
-                    "state": "disabled"
+                    "state": "enabled"
                 }
             },
+            "minSupportedVersion": "0.100.0",
             "settings": {
                 "aiChatURL": "https://duckduckgo.com/?q=DuckDuckGo+AI+Chat&ia=chat&duckai=3",
                 "onboardingCookieName": "dcm",
                 "onboardingCookieDomain": "duckduckgo.com",

@petevb petevb self-assigned this Feb 6, 2025
@petevb petevb enabled auto-merge February 6, 2025 18:59
petevb
petevb previously approved these changes Feb 6, 2025
Copy link

@petevb petevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@petevb petevb added this pull request to the merge queue Feb 6, 2025
@Jonathan-L Jonathan-L removed this pull request from the merge queue due to a manual request Feb 6, 2025
Copy link

@petevb petevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking @Jonathan-L!
:shipit:

@Jonathan-L Jonathan-L added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit ad42286 Feb 6, 2025
8 checks passed
@Jonathan-L Jonathan-L deleted the jonathan/enable-aichat branch February 6, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants