Merge branch 'main' into la/live-pixel-validator

README.md

@@ -74,10 +74,10 @@ To validate:
 ```
 $ cd ${RepoSpecificPixelFolder}
 $ npm i
-$ npx validate-defs .
+$ npx validate-ddg-pixel-defs .
 ```
 
-To validate a single file, you can use `npx validate-defs . -f ${path to file relative to pixels/ directory}`
+To validate a single file, you can use `npx validate-ddg-pixel-defs . -f ${path to file relative to pixels/ directory}`
 
 Validation will also run as part of CI.
 

bin/validate_live_pixel.mjs

@@ -1,3 +1,5 @@
+#!/usr/bin/env node
+
 import fs from 'fs';
 import JSON5 from 'json5';
 

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@duckduckgo/pixel-schema",
-    "version": "1.0.3",
+    "version": "1.0.5",
     "files": [
         "bin",
         "schemas",

tests/live_pixel_validation_test.mjs

@@ -46,6 +46,13 @@ describe('No common params nor suffixes', () => {
         const expectedErrors = ["must NOT have additional properties. Found extra property 'param2'"];
         expect(errors).to.have.members(expectedErrors);
     });
+
+    it('ignores cache buster', () => {
+        const prefix = 'simplePixel';
+        const url = `/t/${prefix}?12345&param1=true`;
+        const errors = paramsValidator.validateLivePixels(pixelDefs[prefix], prefix, url);
+        expect(errors).to.be.empty;
+    });
 });
 
 describe('Common params', () => {