Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always open Watch In Youtube links in a new tab #3740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afterxleep
Copy link
Contributor

@afterxleep afterxleep commented Jan 15, 2025

Task/Issue URL: https://app.asana.com/0/1204099484721401/1207942134403719/f
Tech Design URL:
CC:

Description:
Always Open “Watch in Youtube” links in a new tab. This fixes a lot of back-forward navigation with DuckPlayer in the same tab, incluiding the task above

Steps to test this PR:

  • 1. Go to Settings > DuckPlayer
  • 2. Disable “Open Duck Player in a new tab, whenever possible”
  • 3. Enable “Always open Youtube videos in Duck Player"
  • 4. Go to https://www.youtube.com/@mkbhd
  • 5. Open a Video, which should open in Duck Player and make sure it’s playing
  • 6. Click “Watch in Youtube” button at the bottom.
  • 7. Confirm the video opens in a new tab, and the previous video pauses.
  • 8. Hit the back button, and confirm the newly opened tab is closed and you’re back to the paused video.

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant