Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix circular reference in AddressBarModel #3733

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1201048563534612/1209158272007943/f

Description:

  • fix circular reference in AddressBarModel causing video not stopping after closing a window

Steps to test this PR:

  1. Open Settings
  2. Open a video
  3. Close the window, validate video stops playing

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from ayoy January 15, 2025 11:54
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great @mallexxx! I tried main branch where I could reproduce the issue, and it's gone on this branch. Sorry for introducing the bug 😬

@mallexxx mallexxx merged commit b47c5a2 into release/1.122.0 Jan 16, 2025
34 checks passed
@mallexxx mallexxx deleted the alex/fix-settings-capturing-tabs branch January 16, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants