Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify connecting sync accounts when two exist #3680

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

graeme
Copy link
Collaborator

@graeme graeme commented Dec 19, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208944782348823/f

Description:

Around 600 daily Sync users try to connect a Synced device with another Sync Backup, which is not possible, and we show them an error indicating they should stop syncing first and try again.

Simplify the steps by:

  • Automatically Switch Sync for users with no other devices connected. (This is the most common scenario) -
  • Ask, and allow them to continue switching sync for users with more devices connected.

Steps to test this PR:
https://app.asana.com/0/0/1208993297756834/f

also confirm that pixels are sent:
https://app.asana.com/0/1142021229838617/1208928557675008/f

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@graeme graeme requested a review from amddg44 December 19, 2024 13:04
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 52a0d4e

@graeme graeme changed the title Simplify connecting sync accounts when 2 Simplify connecting sync accounts when two exist Dec 19, 2024
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and really nice work on testing!

Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants