Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual variant builds to fail without cancelling others #1955

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Dec 11, 2023

Task/Issue URL: https://app.asana.com/0/1203301625297703/1206145260961053/f

Description:
Disable fail-fast flag for the variants matrix so that a single failed job won't cause others to get cancelled.

Steps to test this PR:

  1. Check out this workflow run and verify that 1 of 10 jobs has failed, but others have successfully completed.
  2. Check out the re-run and verify that all jobs are successful.
  3. Check out the usage for that workflow and verify that only the lc job was billed (run) twice.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test steps look great, and the billing page checks out as well. 👍 Thanks for this one! It should make the Monday release process even smoother.

@ayoy ayoy merged commit 13a5a90 into main Dec 11, 2023
40 checks passed
@ayoy ayoy deleted the dominik/gha-variants-disable-fail-fast branch December 11, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants