Fix VPN IPv6 connectivity #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 11, 2023
Required: Task/Issue URL: https://app.asana.com/0/0/1206136376883995/f iOS PR: duckduckgo/iOS#2258 macOS PR: duckduckgo/macos-browser#1954 What kind of version bump will this require?: Major Description: This PR fixes a regression related to IPv6.
|
Test report seems to have gotten out of sync somehow, but I'll merge this PR as it's updating the macOS browser to a breaking BSK version. I ran these tests a few times and it looked like the Privacy Test Pages site was having issues, but it has settled down now. |
samsymons
added a commit
that referenced
this pull request
Dec 11, 2023
Task/Issue URL: https://app.asana.com/0/0/1206136376883995/f Tech Design URL: CC: Description: This PR pulls in an IPv6 fix.
ayoy
pushed a commit
that referenced
this pull request
Dec 12, 2023
Task/Issue URL: https://app.asana.com/0/0/1206136370427438/f Description: This PR pulls in an IPv6 fix from #1954. The BSK bump in this PR was the next tag after the version used in the 1.68.0 release, so no hotfix branch/tag was needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206136376883995/f
Tech Design URL:
CC:
Description:
This PR pulls in an IPv6 fix.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation