Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash with wrong constraint #1738

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix crash with wrong constraint #1738

merged 1 commit into from
Oct 9, 2023

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Oct 9, 2023

Task/Issue URL: https://app.asana.com/0/1177771139624306/1205677294210571/f

Description:
Fix issue that was causing Xcode to crash when the fire button was clicked

Steps to test this PR:

  1. Open app from Xcode
  2. Use Fire button
  3. Check if there's no regression to this task

tomasstrba
tomasstrba approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@Bunn Bunn merged commit f414302 into release/1.59.3 Oct 9, 2023
17 checks passed
@Bunn Bunn deleted the bunn/fix/fire-crash branch October 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasstrba tomasstrba tomasstrba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @tomasstrba