-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scan and optout support for child sites #1681
Add scan and optout support for child sites #1681
Conversation
- Do not save a preferredRunDate if optOut is on the parent
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DataBroker.swift
Show resolved
Hide resolved
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/Step.swift
Show resolved
Hide resolved
...tection/Sources/DataBrokerProtection/Operations/DataBrokerProfileQueryOperationManager.swift
Outdated
Show resolved
Hide resolved
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DataBroker.swift
Outdated
Show resolved
Hide resolved
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/ScanOperation.swift
Outdated
Show resolved
Hide resolved
...s/DataBrokerProtection/Operations/UseCases/UpdateChildSitesScanPreferredRunDateUseCase.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and it seems to be working fine, but there are some comments here I'd like to know your opinion about. The most important ones are:
https://github.com/duckduckgo/macos-browser/pull/1681/files#r1339204488 and https://github.com/duckduckgo/macos-browser/pull/1681/files#r1339200002
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing the comments.
…-remote-fetching # By Alexey Martemyanov (1) and others # Via GitHub * develop: Add scan and optout support for child sites (#1681) Connection interruption simulation option (#1686) Resolve naming inconsistencies (#1692) Improve Asana integration for failed PR checks (#1673) Favicon store refactoring (#1674) Update BSK with autofill 8.4.1 (#1687) # Conflicts: # DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionAppEvents.swift
…-pixels * develop: Update Sparkle to 2.5.0 (#1645) Opt-out pixels improvements (#1694) Run DBP tests on the CI (#1682) Fix for Autofill sections not sorting correctly (#1677) Add scan and optout support for child sites (#1681) Connection interruption simulation option (#1686) Resolve naming inconsistencies (#1692)
Asana task
https://app.asana.com/0/1204006570077678/1205508328452433/f
Description
Goal: We will scan on the parent sites and child sites, but we will only opt out of the parent.
This will be the process:
preferredRunDate
set tonil
, that’s because we do not run that operation, but we need it on the database to show it on the UISteps to test this PR