Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scan and optout support for child sites #1681

Merged

Conversation

jotaemepereira
Copy link
Collaborator

Asana task

https://app.asana.com/0/1204006570077678/1205508328452433/f

Description

Goal: We will scan on the parent sites and child sites, but we will only opt out of the parent.

This will be the process:

  • We do scans on both types of sites
  • When we find matches on a child site, we create an opt-out operation but with the preferredRunDate set to nil, that’s because we do not run that operation, but we need it on the database to show it on the UI
  • When an opt-out is finished on a parent site, we execute the new use case. The use case will take care of fetching all the child broker sites, and it will update their scan preferred run date to the confirm opt-out date set on its JSON file.

Steps to test this PR

  1. Do a search that has results both in the parent and child sites
  2. Initialize the opt-out process
  3. The only opt-out that should be run should be the parent. No child sites should run the opt-out
  4. When the parent opt-out finishes, the scan preferred run date should change on the child sites
  5. Then is business as usual. Scans will be run again on the parent and child, to either find new matches or confirm if a match was removed.

@jotaemepereira jotaemepereira requested a review from Bunn September 26, 2023 19:51
Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and it seems to be working fine, but there are some comments here I'd like to know your opinion about. The most important ones are:
https://github.com/duckduckgo/macos-browser/pull/1681/files#r1339204488 and https://github.com/duckduckgo/macos-browser/pull/1681/files#r1339200002

@jotaemepereira jotaemepereira requested a review from Bunn September 28, 2023 16:58
Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing the comments.

@jotaemepereira jotaemepereira merged commit d020765 into develop Sep 28, 2023
@jotaemepereira jotaemepereira deleted the juan/dbp/add-scan-and-optout-support-child-sites branch September 28, 2023 19:36
samsymons added a commit that referenced this pull request Sep 28, 2023
…-remote-fetching

# By Alexey Martemyanov (1) and others
# Via GitHub
* develop:
  Add scan and optout support for child sites (#1681)
  Connection interruption simulation option (#1686)
  Resolve naming inconsistencies (#1692)
  Improve Asana integration for failed PR checks (#1673)
  Favicon store refactoring (#1674)
  Update BSK with autofill 8.4.1 (#1687)

# Conflicts:
#	DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionAppEvents.swift
samsymons added a commit that referenced this pull request Oct 2, 2023
…-pixels

* develop:
  Update Sparkle to 2.5.0 (#1645)
  Opt-out pixels improvements (#1694)
  Run DBP tests on the CI (#1682)
  Fix for Autofill sections not sorting correctly (#1677)
  Add scan and optout support for child sites (#1681)
  Connection interruption simulation option (#1686)
  Resolve naming inconsistencies (#1692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants