Issue with extension script not being applied on the tab URL change r…

…esolved
duckduckgo · Jan 29, 2025 · ac5617a · ac5617a
1 parent 5f6c722
commit ac5617a
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/DuckDuckGo/PinnedTabs/Model/PinnedTabsManager.swift b/DuckDuckGo/PinnedTabs/Model/PinnedTabsManager.swift
@@ -35,6 +35,10 @@ final class PinnedTabsManager {
         } else {
             tabCollection.append(tab: tab)
         }
+
+        if #available(macOS 14.4, *) {
+            WebExtensionManager.shared.eventsListener.didChangeTabProperties([.pinned], for: tab)
+        }
     }
 
     func unpinTab(at index: Int, published: Bool = false) -> Tab? {
@@ -47,6 +51,10 @@ final class PinnedTabsManager {
             return nil
         }
         didUnpinTabSubject.send(index)
+
+        if #available(macOS 14.4, *) {
+            WebExtensionManager.shared.eventsListener.didChangeTabProperties([.pinned], for: tab)
+        }
         return tab
     }
 

diff --git a/DuckDuckGo/Tab/Model/Tab.swift b/DuckDuckGo/Tab/Model/Tab.swift
@@ -462,6 +462,9 @@ protocol NewWindowPolicyDecisionMaker {
             if navigationDelegate.currentNavigation == nil {
                 updateCanGoBackForward(withCurrentNavigation: nil)
             }
+            if #available(macOS 14.4, *) {
+                WebExtensionManager.shared.eventsListener.didChangeTabProperties([.URL], for: self)
+            }
         }
     }
 
@@ -532,7 +535,13 @@ protocol NewWindowPolicyDecisionMaker {
 
     var lastSelectedAt: Date?
 
-    @Published var title: String?
+    @Published var title: String? {
+        didSet {
+            if #available(macOS 14.4, *) {
+                WebExtensionManager.shared.eventsListener.didChangeTabProperties([.title], for: self)
+            }
+        }
+    }
 
     private func updateTitle() {
         if let error {
@@ -559,7 +568,13 @@ protocol NewWindowPolicyDecisionMaker {
     }
     let permissions: PermissionModel
 
-    @Published private(set) var isLoading: Bool = false
+    @Published private(set) var isLoading: Bool = false {
+        didSet {
+            if #available(macOS 14.4, *) {
+                WebExtensionManager.shared.eventsListener.didChangeTabProperties([.loading], for: self)
+            }
+        }
+    }
     @Published private(set) var loadingProgress: Double = 0.0
 
     /// an Interactive Dialog request (alert/open/save/print) made by a page to be published and presented asynchronously
@@ -836,6 +851,10 @@ protocol NewWindowPolicyDecisionMaker {
     func muteUnmuteTab() {
         webView.audioState.toggle()
         objectWillChange.send()
+
+        if #available(macOS 14.4, *) {
+            WebExtensionManager.shared.eventsListener.didChangeTabProperties([.muted], for: self)
+        }
     }
 
     private enum ReloadIfNeededSource {

diff --git a/DuckDuckGo/Tab/ViewModel/TabViewModel.swift b/DuckDuckGo/Tab/ViewModel/TabViewModel.swift
@@ -86,6 +86,10 @@ final class TabViewModel {
             if oldValue != zoomLevel {
                 zoomLevelSubject.send(zoomLevel)
             }
+
+            if #available(macOS 14.4, *) {
+                WebExtensionManager.shared.eventsListener.didChangeTabProperties([.zoomFactor], for: tab)
+            }
         }
     }