Skip to content

Commit

Permalink
Testing of App Store build crash path still needs to be done
Browse files Browse the repository at this point in the history
  • Loading branch information
jdjackson committed Dec 16, 2024
1 parent a972c9c commit 7988dcb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion DuckDuckGo/Application/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
let fileStore: FileStore

#if APPSTORE
private let crashCollection = CrashCollection(CrashReportSender(platform: .macOSAppStore))
private let crashCollection = CrashCollection(crashReportSender: CrashReportSender(platform: .macOSAppStore,
pixelEvents: CrashReportSender.pixelEvents))

Check failure on line 74 in DuckDuckGo/Application/AppDelegate.swift

View workflow job for this annotation

GitHub Actions / Test (Sandbox)

incorrect argument label in call (have 'crashReportSender:', expected 'platform:')

Check failure on line 74 in DuckDuckGo/Application/AppDelegate.swift

View workflow job for this annotation

GitHub Actions / Test (Sandbox)

cannot convert value of type 'CrashReportSender' to expected argument type 'CrashCollectionPlatform'
#else

Check failure on line 75 in DuckDuckGo/Application/AppDelegate.swift

View workflow job for this annotation

GitHub Actions / Test (Sandbox)

extra argument 'pixelEvents' in call
private let crashReporter = CrashReporter()
#endif
Expand Down Expand Up @@ -444,6 +445,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
applyPreferredTheme()

#if APPSTORE
// TODO: This path still needs testing
crashCollection.startAttachingCrashLogMessages { pixelParameters, payloads, completion in
pixelParameters.forEach { parameters in

Check failure on line 450 in DuckDuckGo/Application/AppDelegate.swift

View workflow job for this annotation

GitHub Actions / SwiftLint

TODOs should be resolved (This path still needs testing) (todo)
PixelKit.fire(GeneralPixel.crash, withAdditionalParameters: parameters, includeAppVersionParameter: false)
Expand Down

0 comments on commit 7988dcb

Please sign in to comment.