Skip to content

Commit

Permalink
Lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
afterxleep committed Nov 12, 2024
1 parent abf4a2a commit 186c699
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions DuckDuckGo/Statistics/GeneralPixel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,15 @@ enum GeneralPixel: PixelKitEventV2 {
case duckPlayerNewTabSettingsOff
case duckPlayerContingencySettingsDisplayed
case duckPlayerContingencyLearnMoreClicked

// Temporary Overlay Pixels
case duckPlayerYouTubeOverlayNavigationBack
case duckPlayerYouTubeOverlayNavigationRefresh
case duckPlayerYouTubeNavigationWithinYouTube
case duckPlayerYouTubeOverlayNavigationOutsideYoutube
case duckPlayerYouTubeOverlayNavigationClosed
case duckPlayerYouTubeNavigationIdle30

// Dashboard
case dashboardProtectionAllowlistAdd(triggerOrigin: String?)
case dashboardProtectionAllowlistRemove(triggerOrigin: String?)
Expand Down Expand Up @@ -1124,7 +1124,7 @@ enum GeneralPixel: PixelKitEventV2 {
case .pageRefreshThreeTimesWithin20Seconds: return "m_mac_reload-three-times-within-20-seconds"
case .siteNotWorkingShown: return "m_mac_site-not-working_shown"
case .siteNotWorkingWebsiteIsBroken: return "m_mac_site-not-working_website-is-broken"

}
}

Expand Down
6 changes: 3 additions & 3 deletions DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,14 @@ extension DuckPlayerTabExtension: NavigationResponder {
navigator.load(URLRequest(url: .duckPlayer(videoID, timestamp: timestamp)))
}
}

// Fire DuckPlayer Temporary Pixels on Reload
if case .reload = navigationAction.navigationType {
if let url = navigationAction.request.url {
duckPlayerOverlayUsagePixels.handleNavigationAndFirePixels(url: url, duckPlayerMode: duckPlayer.mode)
}
}

// when in Private Player, don't directly reload current URL when it‘s a Private Player target URL
if case .reload = navigationAction.navigationType,
navigationAction.url.isDuckPlayer {
Expand Down Expand Up @@ -281,7 +281,7 @@ extension DuckPlayerTabExtension: NavigationResponder {
webView.goBack()
webView.load(URLRequest(url: .duckPlayer(videoID, timestamp: timestamp)))
}

// Fire DuckPlayer Overlay Temporary Pixels
if let url = navigation.request.url {
duckPlayerOverlayUsagePixels.handleNavigationAndFirePixels(url: url, duckPlayerMode: duckPlayer.mode)
Expand Down

0 comments on commit 186c699

Please sign in to comment.