Address updater feedback #14808
Annotations
10 errors and 12 warnings
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, failed - Phishing request loaded
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L133
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, failed - Phishing request loaded
|
|
Run integration tests:
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L133
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Upload failed unit tests xcresult
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L194
capture of 'flow' with non-sendable type 'NEAppProxyTCPFlow?' in a `@Sendable` closure
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'NetworkExtension'
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
Loading