Address updater feedback #14807
quanganhdopr.yml
on: pull_request
Matrix: Test
SwiftLint
43s
Test Shell Scripts
16s
Make Release Build
7m 12s
Verify autoconsent bundle
30s
ShellCheck
7s
Annotations
14 errors and 37 warnings
|
SwiftLint:
DuckDuckGo/Updates/ReleaseNotesUserScript.swift#L83
Lines should not have trailing whitespace (trailing_whitespace)
|
|
SwiftLint:
DuckDuckGo/Updates/UpdateUserDriver.swift#L219
Lines should not have trailing whitespace (trailing_whitespace)
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, failed - Phishing request loaded
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L133
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, failed - Phishing request loaded
|
|
Test (Non-Sandbox):
IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L133
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
Test (Sandbox)
error: stat(/Users/runner/work/macos-browser/macos-browser/DerivedData/Build/Products/CI/DuckDuckGo Personal Information Removal App Store.app/Contents/Frameworks/Common.framework/Versions/A/Resources/Info.plist): No such file or directory (2) (in target 'DuckDuckGoDBPBackgroundAgentAppStore' from project 'DuckDuckGo')
|
|
Test (Sandbox)
Process completed with exit code 1.
|
|
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Verify autoconsent bundle
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Make Release Build:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L194
capture of 'flow' with non-sendable type 'NEAppProxyTCPFlow?' in a `@Sendable` closure
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'NetworkExtension'
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
|
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Test (Non-Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Non-Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L194
capture of 'flow' with non-sendable type 'NEAppProxyTCPFlow?' in a `@Sendable` closure
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'NetworkExtension'
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
|
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Test (Sandbox)
No files were found with the provided path: Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
|
Test (Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L194
capture of 'flow' with non-sendable type 'NEAppProxyTCPFlow?' in a `@Sendable` closure
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'NetworkExtension'
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
Non-Sandbox-integrationtests-xcodebuild.log
|
182 KB |
|
|
Non-Sandbox-integrationtests.xcresult
|
90.4 MB |
|
|
Non-Sandbox-unittests-xcodebuild.log
|
1.09 MB |
|
|
Sandbox-integrationtests-xcodebuild.log
|
47.8 KB |
|
|
Sandbox-integrationtests.xcresult
|
195 KB |
|
|
Sandbox-unittests-xcodebuild.log
|
1.81 MB |
|