Convert Verecor child sites to be parent sites #14756
Triggered via pull request
December 19, 2024 09:52
brianhall
Status
Success
Total duration
12m 36s
Artifacts
–
pr.yml
on: pull_request
Matrix: Test
SwiftLint
41s
Test Shell Scripts
19s
Make Release Build
7m 47s
Verify autoconsent bundle
34s
ShellCheck
6s
Annotations
18 errors, 36 warnings, and 1 notice
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:158 - XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:180 - failed - -[MaliciousSiteProtectionIntegrationTests testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing]: Phishing request loaded for http://privacy-test-pages.site/security/badware/phishing.html
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests App Store.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests App Store.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests App Store.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests App Store.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:158 - XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
|
|
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests App Store.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:180 - failed - -[MaliciousSiteProtectionIntegrationTests testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing]: Phishing request loaded for http://privacy-test-pages.site/security/badware/phishing.html
|
|
MoreOptionsMenuTests.testThatMoreOptionMenuHasTheExpectedItemsWhenFreemiumFeatureAvailable:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MoreOptionsMenuTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Menus/MoreOptionsMenuTests.swift:194 - XCTAssertEqual failed: ("Update Available - Install Now") is not equal to ("Send Feedback")
|
|
MoreOptionsMenuTests.testThatMoreOptionMenuHasTheExpectedItemsWhenFreemiumFeatureUnavailable:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MoreOptionsMenuTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Menus/MoreOptionsMenuTests.swift:162 - XCTAssertEqual failed: ("Update Available - Install Now") is not equal to ("Send Feedback")
|
|
MoreOptionsMenuTests.testWhenBrowserIsNotDefaultThenSetAsDefaultBrowserMenuItemIsShown:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MoreOptionsMenuTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Menus/MoreOptionsMenuTests.swift:321 - XCTAssertEqual failed: ("") is not equal to ("Set DuckDuckGo As Default Browser")
|
|
MoreOptionsMenuTests.testWhenClickingOnBookmarkAllTabsMenuItemThenTheActionDelegateIsAlerted:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MoreOptionsMenuTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Menus/MoreOptionsMenuTests.swift:292 - XCTUnwrap failed: throwing "NSRangeException: *** -[__NSFrozenArrayM objectAtIndex:]: index 18446744073709551615 beyond bounds [0 .. 6]"
|
|
MoreOptionsMenuTests.testThatMoreOptionMenuHasTheExpectedItemsWhenFreemiumFeatureAvailable:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MoreOptionsMenuTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Menus/MoreOptionsMenuTests.swift:194 - XCTAssertEqual failed: ("Update Available - Install Now") is not equal to ("Send Feedback")
|
|
MoreOptionsMenuTests.testThatMoreOptionMenuHasTheExpectedItemsWhenFreemiumFeatureUnavailable:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MoreOptionsMenuTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Menus/MoreOptionsMenuTests.swift:162 - XCTAssertEqual failed: ("Update Available - Install Now") is not equal to ("Send Feedback")
|
|
MoreOptionsMenuTests.testWhenBrowserIsNotDefaultThenSetAsDefaultBrowserMenuItemIsShown:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MoreOptionsMenuTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Menus/MoreOptionsMenuTests.swift:321 - XCTAssertEqual failed: ("") is not equal to ("Set DuckDuckGo As Default Browser")
|
|
MoreOptionsMenuTests.testWhenClickingOnBookmarkAllTabsMenuItemThenTheActionDelegateIsAlerted:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MoreOptionsMenuTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Menus/MoreOptionsMenuTests.swift:292 - XCTUnwrap failed: throwing "NSRangeException: *** -[__NSFrozenArrayM objectAtIndex:]: index 18446744073709551615 beyond bounds [0 .. 6]"
|
|
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Verify autoconsent bundle
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Make Release Build:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Make Release Build:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Test (Non-Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Non-Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Non-Sandbox):
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L135
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Test (Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Test (Sandbox):
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Private API Report / Update PR comment
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|