Implement tab bar remote message #14708
Annotations
10 errors, 12 warnings, and 5 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40775b670> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000013704d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1723115a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000501dfa0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4077a5230> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600005019d90> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40745e710> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000050f82c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x122713ed0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001327650> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17eea2060> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000137eb50> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17eaa65c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000132c210> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1723af530> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001366730> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17227bda0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000132fe90> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4057cce50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000050e9ad0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16fd54c00> should deallocate", "<DuckDuckGo_WebView: 0x1168f1810> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4074e3d70> should deallocate", "<DuckDuckGo_WebView: 0x4074b7ca0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4075e28e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001374b00> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4075dee30> should deallocate", "<DuckDuckGo_WebView: 0x4075df740> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x172364900> should deallocate", "<DuckDuckGo_WebView: 0x172365480> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1238716b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000501c160> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x407551130> should deallocate", "<DuckDuckGo_WebView: 0x4075cbc60> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17236c770> should deallocate", "<DuckDuckGo_WebView: 0x17236ce20> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17e8fc320> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600005002940> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1238e7990> should deallocate", "<DuckDuckGo_WebView: 0x407723700> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40bb044e0> should deallocate", "<DuckDuckGo_WebView: 0x1723d1960> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17c7d0070> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001328580> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4075cdf50> should deallocate", "<DuckDuckGo_WebView: 0x4075254c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x407760b10> should deallocate", "<DuckDuckGo_WebView: 0x4077611b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x407527400> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001361080> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x172380820> should deallocate", "<DuckDuckGo_WebView: 0x1723fd610> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x407768d30> should deallocate", "<DuckDuckGo_WebView: 0x4077693e0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x172380650> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000501c0b0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4074d0b20> should deallocate", "<DuckDuckGo_WebView: 0x4074d4f10> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x172367680> should deallocate", "<DuckDuckGo_WebView: 0x17239c0b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4140fc8d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001359760> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x176286060> should deallocate", "<DuckDuckGo_WebView: 0x176286a70> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1763f9420> should deallocate", "<DuckDuckGo_WebView: 0x1763f9f80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4074d0830> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600005019340> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x176280810> should deallocate", "<DuckDuckGo_WebView: 0x176280a70> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1762c7260> should deallocate", "<DuckDuckGo_WebView: 0x1762c7b30> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Upload failed unit tests xcresult
No files were found with the provided path: Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Run integration tests
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Loading