Skip to content

Look up lowercased URLs in lowercased items dict (#3658) #14690

Look up lowercased URLs in lowercased items dict (#3658)

Look up lowercased URLs in lowercased items dict (#3658) #14690

Triggered via push December 11, 2024 20:18
Status Failure
Total duration 13m 23s
Artifacts 3

pr.yml

on: push
Matrix: Test
SwiftLint
44s
SwiftLint
Test Shell Scripts
19s
Test Shell Scripts
Make Release Build
7m 21s
Make Release Build
Verify autoconsent bundle
27s
Verify autoconsent bundle
ShellCheck
11s
ShellCheck
Private API Report  /  Update PR comment
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

16 errors, 36 warnings, and 2 notices
MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:51 - failed - Phishing request loaded
MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/MaliciousSiteProtectionIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift:180 - failed - -[MaliciousSiteProtectionIntegrationTests testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing]: Phishing request loaded for http://privacy-test-pages.site/security/badware/phishing.html
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, failed - Phishing request loaded
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L133
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, failed - Phishing request loaded
Test (Non-Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L133
testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
Test (Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L51
testPhishingDetected_tabIsMarkedPhishing, failed - Phishing request loaded
Test (Sandbox): IntegrationTests/MaliciousSiteProtection/MaliciousSiteProtectionIntegrationTests.swift#L101
testPhishingDetected_tabIsMarkedPhishing, XCTAssertEqual failed: ("nil") is not equal to ("Optional(MaliciousSiteProtection.MaliciousSiteError(code: MaliciousSiteProtection.MaliciousSiteError.Code.phishing, failingUrl: http://privacy-test-pages.site/security/badware/phishing.html))")
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Verify autoconsent bundle
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Make Release Build: LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Make Release Build: LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Make Release Build: LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Make Release Build: LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Non-Sandbox): LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Non-Sandbox): LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox): LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Sandbox): LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Test (Sandbox): LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox)
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel

Artifacts

Produced during runtime
Name Size
Non-Sandbox-integrationtests-xcodebuild.log Expired
178 KB
Non-Sandbox-integrationtests.xcresult Expired
90.1 MB
Non-Sandbox-unittests-xcodebuild.log Expired
1.09 MB