Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSK -> alex/malware-protection-pixels #3735

Merged
merged 6 commits into from
Dec 24, 2024
Merged

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Dec 18, 2024

Task/Issue URL: https://app.asana.com/0/1202406491309510/1208997802565798/f
BSK PR: duckduckgo/BrowserServicesKit#1134
macOS PR: duckduckgo/macos-browser#3672

Description:

  • Update BSK ref for malicious site protection pixel definitions

Steps to test this PR:

  1. Validate CI is green

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Dec 20, 2024
@mallexxx mallexxx merged commit 1da9230 into main Dec 24, 2024
13 checks passed
@mallexxx mallexxx deleted the alex/malware-protection-pixels branch December 24, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants