Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding protectionsState to breakage form #2313

Merged
merged 1 commit into from
Nov 2, 2023
Merged

adding protectionsState to breakage form #2313

merged 1 commit into from
Nov 2, 2023

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 1, 2023 •
edited
Loading

Reviewer: @sammacbeth

https://app.asana.com/0/0/1205842954277156/f

Parent Task: https://app.asana.com/0/72649045549333/1205644489547731/f

Description:

Adds a new parameter to breakage form submissions.

Steps to test this PR:

  1. submit the form breakage form
  2. verify that the param protectionsState has either a "0" or "1" value based on the rules mentioned in the Asana task.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@shakyShane
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@shakyShane shakyShane requested a review from sammacbeth November 1, 2023 16:12
@sammacbeth sammacbeth merged commit 8e765d9 into main Nov 2, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammacbeth sammacbeth sammacbeth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakyShane @sammacbeth